Mail Merge not working

As an aside, it might be easier to just have a text field for the series number and manage it manually, especially if sometimes it comes from one place and sometimes another. If you’re only excluding numbers within a range (e.g. 20, 21 and 22 in the example), then you could still script it though it’s a little more work to mask those numbers but not impossible.

One other thought is to copy/paste through an online Javascript beautifier like beautifier.io. Attached is what it looked at a first pass (I also had to fix the smart quotes). The indentation change makes it clear where the problem is and taking it out results in everything being indented properly. If I move over to jslint.com I can paste it and it’ll give me a slightly different error message:

1. [JSLint was unable to finish] Expected ‘(end)’ and instead saw ‘}’.
}

Here is the code with a few more changes, but it still won’t work:

function Get_Zertifikatsnummer() {

    // Get the Zertificatsnummer from the Seriennummern form

    var Seriennummern_form_id = "fld-123…";
    var Seriennummern_form = record.getFieldValue(Seriennummern_form_id);
    var name_id = "fld-abc…";
    var name_value = Seriennummern_form.getFieldValue(name_id);

    // Get the Print Registry, create a new record in it and set the value in a field

    var get_zertifikatsnummer = document.getFormNamed("Print Registry")
    var name_id = "fld-xyz…";
    var seriennummer_record = get_zertifikatsnummer.addNewRecord();
    seriennummer_record.setFieldValue(field_id, name_value);

    form.saveAllChanges()

}

Why won’t it work? Well this line:

    var Seriennummern_form = record.getFieldValue(Seriennummern_form_id);

This line doesn’t return a Tap Forms record but returns an array of records, perhaps think of it like a bag. You need to loop over it to get a scalar or single value. Now there is a kind of quick way that will get you a comma separated list of fields, it looks like this:

    var name_value = record.getFieldValue(Seriennummern_form_id).map((rec) => rec.getFieldValue(name_id)).join(", ");

This is a bit of black magic and is a little unreadable but unpacking:

• record.getFieldValue(Seriennummern_form_id) will give us all of the child records, I’m assuming this is your link to the serial number form.
• map is a special function that says take this value (in case rec which is technically a TFFormEntry) and then replace it with the result of the other command (in this case rec.getFieldValue(name_id) which I’m guessing is the serial number). So now instead of it all being child records, it’s the serial numbers.
• Now that we’re dealing with just the serial numbers in the array, we can do join(", ") to make them into a comma separated list (technically it’s comma and then space since it’s ,).

I suspect that’s what you’re after and will give you a quick start for that field. You could still loop to replace contiguous numbers but I feel doing some of it by hand might be ok whilst you learn.

Here’s my final script with a few extra changes. I ran this through JSLint and fixed each of it’s complaints (e.g. there wasn’t a field_id and there was two name_id fields, so I renamed the second one to be field_id). I also added a call to the function, otherwise the script will do nothing (e.g. the Get_Zertifikatsnummer(); line at the end).

function Get_Zertifikatsnummer() {

    // Get the Zertificatsnummer from the Seriennummern form
    var Seriennummern_form_id = "fld-123…";
    var name_id = "fld-abc…";
    var name_value = record.getFieldValue(Seriennummern_form_id)
        .map((rec) => rec.getFieldValue(name_id))
        .join(", ");

    // Get the Print Registry, create a new record in it and set the value in a field
    var get_zertifikatsnummer = document.getFormNamed("Print Registry");
    var field_id = "fld-xyz…";
    var seriennummer_record = get_zertifikatsnummer.addNewRecord();
    seriennummer_record.setFieldValue(field_id, name_value);

    form.saveAllChanges();
}

Get_Zertifikatsnummer();

One other note, if there is a field in this form that links to the Print Registry then you should use record.addNewRecordToField(link_field_id) which will not only create a new record in the target form for you but also create the linking metadata as well.

My brother says the hardest part about coding is knowing what you result you want to appear.
I beg to differ. I know what I want to appear, but don’t know the magic formula for that yet.

Once you know how to code I can see the first taking over but you’ve got to learn how to put the code together. That takes some time to figure out the pieces.

So I will repeat my (thought) process here, maybe you will see my error:
1. I import a list of 6 digit series numbers as a .csv file into the file “Seriennummern”. The .csv-file is exported from Numbers, so I reduce the likelihood of typos.You can easily create an ascending digit column in Numbers by typing in the first two fields, marking them and dragging the curser down the column.

At some point this should become a script you run in TF to generate the entries so you don’t have to import a CSV file just to generate a series.

2. I input information in the print registry, like Title, format, etc.
3. I choose the “Zertifikatsnummer”. I have this as a one to many field
4. The series of the certificate numbers, “Fortlaufende Hologrammnummern der Serie” is also a one to many field. Explanation: I must express in the certificate print form how many of Print X is made and what series numbers this print edition will have.
5. I will print out the certificate, affix the appropriate hologram to both the print and the certificate

Are both of these link to form fields (“Zertifikatsnummer” and the “Hologrammnummern”) linking to the same “Seriennummern” form? Or are they different series?

I think what you are saying is that it is just better to copy and paste the serial number and the range of serial numbers into a document until I have finished my baby steps. Right?

There was a quote I heard the other day that “You need to get things done before you get bored with them” and I’d substitute “bored” with “frustrated” in this case. There is a pragmatic path to getting unblocked and the long term process improvements. Learning when you’re stressed is a path to more stress :) Solve the initial problem and come back to making it better :)

(But I still think that having the certificate databank in Tapforms is the best solution for my records, even if I cannot automatically output a certificate. I can add the images and still have a record of the series of certificate numbers)
…
So, I have taken a work-around, because it is impossible to understand/learn coding on the fly for me. I have added some extra fields to copy and paste my numbers into. That does let me do a simple range.

It isn’t an elegant solution, but it will work for me. Thanks for all your efforts on my behalf.

It’s not an elegant solution but it’s something that enables us to have something that works and we can go from there. On the script talk basic information on scripting topic I had started to add some logging. If you run this in the script editor, you should see some output on the console log area on the right:

function Get_Zertifikatsnummer() {

    // Get the Zertificatsnummer from the Seriennummern form
    var Seriennummern_form_id = "fld-123…";
    var Seriennummern_form = record.getFieldValue(Seriennummern_form_id);
    console.log(Seriennummern_form);
    var name_id = 'fld-abc…';
    var name_value = Seriennummern_form
        .map((rec) => rec.getFieldValue(name_id))
        .join(", ");

    console.log(name_value);

    // Get the Print Registry, create a new record in it and set the value in a field
    var get_zertifikatsnummer = document.getFormNamed("Print Registry");
    var field_id = "fld-xyz…";
    var seriennummer_record = get_zertifikatsnummer.addNewRecord();
    console.log(seriennummer_record.getUrl());
    seriennummer_record.setFieldValue(field_id, name_value);

    form.saveAllChanges();
}

Get_Zertifikatsnummer();

This should output some information to help understand the internal state of the script and why things are empty…or where they start being empty :)

No worries, good luck getting it all sorted :)